fix: history tab throws runtime error for multi-source Applications - #282
Conversation
Signed-off-by: Atif Ali <atali@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe application history model now supports optional source fields and per-revision source collections. History rows use shared repository URL rendering for missing, OCI, and external repository URLs. ChangesHistory source rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR fixes a runtime error affecting the history tab for multi-source Applications; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 11.30% 12.34% +1.03%
==========================================
Files 169 171 +2
Lines 6679 6838 +159
Branches 2235 2257 +22
==========================================
+ Hits 755 844 +89
- Misses 5923 5993 +70
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| )} | ||
| <span style={{ marginLeft: '5px' }}> | ||
| {'('} | ||
| {renderRepoUrl(source?.repoURL)} |
There was a problem hiding this comment.
I tested this out and it looks good. For the next release, pull out the style properties (marginLeft, style, etc) in this change to the current history.scss file.

see: GITOPS-10933