fix: cherry-pick: 1.19: Enable Delete ApplicationSet (and apps) for namespace-scoped users(#10780) - #294
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with existing accessReview usage in the same file, and directly addresses namespace-scoped RBAC evaluation for the delete action.
Pull request overview
Enables the “Delete ApplicationSet” action for namespace-scoped users by ensuring the access review for the delete action is performed in the ApplicationSet’s namespace (consistent with the existing patch/update action checks in the same provider).
Changes:
- Add
namespace: applicationSet?.metadata?.namespaceto the delete action’saccessReviewpayload in the ApplicationSet actions provider.
File summaries
| File | Description |
|---|---|
src/gitops/hooks/useApplicationSetActionsProvider.tsx |
Adds namespace-scoped access review context for the ApplicationSet delete action so RBAC evaluation works for namespaced users. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Keith Chong <kykchong@redhat.com>
74cdb1a to
6b3cd17
Compare
See GITOPS-10780. Cherry pick fix back to v1.19