Skip to content

fix: cherry-pick: 1.19: Enable Delete ApplicationSet (and apps) for namespace-scoped users(#10780) - #294

Open
keithchong wants to merge 1 commit into
redhat-developer:v1.19from
keithchong:v1.19-10780-DeleteActionDisabled
Open

fix: cherry-pick: 1.19: Enable Delete ApplicationSet (and apps) for namespace-scoped users(#10780)#294
keithchong wants to merge 1 commit into
redhat-developer:v1.19from
keithchong:v1.19-10780-DeleteActionDisabled

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-10780. Cherry pick fix back to v1.19

@keithchong
keithchong requested review from aali309 and a lite review from Copilot September 2, 2026 14:07
@openshift-ci
openshift-ci Bot requested a review from wtam2018 September 2, 2026 14:07
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 4dbea67c-0b7b-4cc0-b6cd-3ef13ead8930

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, consistent with existing accessReview usage in the same file, and directly addresses namespace-scoped RBAC evaluation for the delete action.

Pull request overview

Enables the “Delete ApplicationSet” action for namespace-scoped users by ensuring the access review for the delete action is performed in the ApplicationSet’s namespace (consistent with the existing patch/update action checks in the same provider).

Changes:

  • Add namespace: applicationSet?.metadata?.namespace to the delete action’s accessReview payload in the ApplicationSet actions provider.
File summaries
File Description
src/gitops/hooks/useApplicationSetActionsProvider.tsx Adds namespace-scoped access review context for the ApplicationSet delete action so RBAC evaluation works for namespaced users.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
keithchong force-pushed the v1.19-10780-DeleteActionDisabled branch from 74cdb1a to 6b3cd17 Compare September 2, 2026 16:22
@keithchong keithchong changed the title fix: cherry-pick: 1.19: Enable Delete ApplicationSet for namespace-scoped users(#10780) fix: cherry-pick: 1.19: Enable Delete ApplicationSet (and apps) for namespace-scoped users(#10780) Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants