Load only the latest checks for monitor bars - #90
Merged
Merged
Conversation
The list ranked every retained check for each monitor just to keep 40 bars. Query each monitor with an indexed limit instead, and index monitor, time, and id so that limit can stop early. Co-authored-by: Tom Schlick <tom@schlick.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The monitors list was slow because each page ranked every retained check for the monitors on that page, then kept 40 bars. At a 60s interval and 30-day retention that is on the order of 40k rows per monitor.
LoadRecentCheckResultsnow loads the latest 40 checks per monitor withORDER BY checked_at DESC, id DESC LIMIT, wrapped so the limit applies on both SQLite and Postgres, and chunked so a status page with a few hundred monitors stays under SQLite's compound-select cap. A new(monitor_id, checked_at, id)index lets that limit stop early. The redundant(monitor_id, checked_at)index is dropped.Bar markup is unchanged: newest 40 checks, oldest first, with the same tooltips.
Test plan
LoadRecentCheckResultsTestcovers a monitor over the limit, one under it, and one with no checks, oldest-first