Repository navigation
fix: pin Review 2.8.0 with package-mode compatibility - #373
Merged
Merged
Conversation
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
HQ SIGN at 851ca73 (dependency). Verified: head is clean with check success; the diff is package.json, bun.lock, docs and tests only, with no src/ change; the lockfile integrity for @rig-c/review@2.8.0 equals npm's (sha512-lA+iTx…lMXA==). Merge with --match-head-commit at this head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin Review exactly to 2.8.0, preserving Parts 2.36.0/Core 3.6.0 and Create's package-only live-host behavior. The new host-port union needs only a schema-discriminant narrowing in the parts-act test helper; no product runtime source changes are included.
Closes #372. Enables the future #278/#317/#356 consumers, which remain parked behind the pilot's step-1 owner act; this PR does not activate API@3/act@4 or reopen ingestion. This in-flight dependency pin is explicitly allowed under HQ's manual-release transition. Exact-head HQ dependency sign is required before merge.
Validation: final focused publication 27 pass, compatibility 3 pass and parts-act 19 pass; typecheck/lint exit 0, with initial typecheck and obsolete Review #555 gate failures preserved. The replacement gate test verifies completed scene-answer/diagnostic carriage and rejects invalid editable options by name. Earlier focused refresh/close/signoff/act/handoff suites pass, and the filled example retains zero refusals/warnings.
A synthetic host opened with Review 2.7.1 accepts the 2.8.0 CLI's ingestion, empty/pending reconciliation and close (exit 0); foreground host readiness is distinct from process exit. No reuse mismatch occurred. All hosts are synthetic; cleanup is verified separately. No live pilot or host action.
Nova generator checks and 32 direction hashes reproduced with installed Review 2.8.0 (run 20261109T132959Z-2100dea87ea7458e89ca498d7f76b9a3, exit 0, 6.55 seconds, quiescent boundary). Its recorded timeout is 3,600 seconds rather than the requested 600-second cap; that historical deviation is retained without a duplicate run. Full acceptance is PR CI. Producer template bytes and question-set identities stay unchanged.