Repository navigation
fix: restore staged Parts 2.37 consumer pins - #391
Merged
Merged
Conversation
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
firejune
added
the
by:codex
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Claude review (cross-family) at exact head Reviewer: Claude (HQ). Read at this head:
No findings. Merge after Checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
Move Create's direct Parts dependency and new-project pin from 3.7.0 to the published 2.37.0, with exact registry integrity and source SHA 463c9ff38b007842e5608d06978ad9e9bd8b2525. Update question-set copies, versioned links and version-bound governed fixtures.
Staged cohort
Core remains 3.7.0. Review remains 3.7.0 at fcc66c03d7f24ea7f4ed68dba8530e5553bbe1d3, with its declared runtime Play 3.7.0 at 60ea660083a1e2535ac3bf3847289f468e5881b9. Create has no direct Play dependency.
Source CI retains all existing sibling-link, entry, child-observation and zero-skip named-test assertions. The asserted runtime edges match their source checkouts. Review's retained devDependency on Parts 3.7.0 remains a separate registry dev edge. The later Review 2.9 consumer PR moves that cohort together. Standalone Play 1.24 publication is a separate release gate.
Verification
The four focused skips comprise three named sibling-source cases and the existing installed-doc-link control. Hosted source-linked CI remains the acceptance for its complete named list and actual sibling graph. A final text-only correction updates the nearby new-project pin prose and removes an unsupported claim that an old breath diagnostic was rerun with the new version. Earlier behavior verification receipts are preserved.
Whole-repository version/range inventory leaves only retained Core/Review/Play 3.7.0 references and enumerator-boundary test vectors. Parts 3.7.0 pin copies and the old Parts source SHA are absent. No release, pilot change, accepted-output regeneration or rigging build is included.
Regenerated fixture field inventory
Only generators whose output embeds the Parts version or its dependent identities ran in write mode. The table includes every recovered fixture path. Hash-only direction/caption changes transitively bind the changed project or producer run identity. Other fixture outputs remained byte-identical under their existing check modes.
templates/example-chain/chain.jsonsteps/[]/output_sha256,steps/[]/outputs/out/run.json,steps/[]/outputs/derived/drafts/chain/out/run.json,steps/[]/outputs/outputs/v1/out/rig/run.json,steps/[]/command/[],steps/[]/seed/value/built_with/@rig-c/parts,steps/[]/outputs/evidence/direction-input.jsontemplates/example-chain/checkpoints/0a-interview-options.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/0a-interview-options/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/0a-interview-options/project.jsoninterview/question_settemplates/example-chain/checkpoints/0b-plan-pending.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/0b-plan-pending/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/0b-plan-pending/project.jsoninterview/question_settemplates/example-chain/checkpoints/1-parts-verdict.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/1-parts-verdict/derived/drafts/chain/out/run.jsonpackage/versiontemplates/example-chain/checkpoints/1-parts-verdict/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/1-parts-verdict/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_settemplates/example-chain/checkpoints/2-rigging-answers.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/2-rigging-answers/derived/drafts/chain/out/run.jsonpackage/versiontemplates/example-chain/checkpoints/2-rigging-answers/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/2-rigging-answers/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_settemplates/example-chain/checkpoints/3-rig-review.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/3-rig-review/derived/drafts/chain/out/run.jsonpackage/versiontemplates/example-chain/checkpoints/3-rig-review/derived/review/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/checkpoints/3-rig-review/outputs/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/checkpoints/3-rig-review/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/3-rig-review/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,versions/[]/built_with/@rig-c/parts,versions/[]/review_package/files/[]/sha256templates/example-chain/checkpoints/4-direction-post.jsonfiles/[]/sha256,project_sha256templates/example-chain/checkpoints/4-direction-post/derived/drafts/chain/out/run.jsonpackage/versiontemplates/example-chain/checkpoints/4-direction-post/derived/review/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/checkpoints/4-direction-post/outputs/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/checkpoints/4-direction-post/package.jsondependencies/@rig-c/partstemplates/example-chain/checkpoints/4-direction-post/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,signoffs/[]/target/review_package/sha256,versions/[]/built_with/@rig-c/parts,versions/[]/review_package/files/[]/sha256templates/example-chain/derived/drafts/chain/out/run.jsonpackage/versiontemplates/example-chain/derived/review/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/evidence/captions.jsoninputs/project/sha256templates/example-chain/evidence/direction-input.jsonscene/sha256templates/example-chain/evidence/direction/v2.jsonscene/sha256templates/example-chain/evidence/scene/s1.jsonrig/acceptance/review_package/sha256templates/example-chain/outputs/v1/out/rig/run.jsonpackage/versiontemplates/example-chain/package.jsondependencies/@rig-c/partstemplates/example-chain/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,scenes/[]/sha256,signoffs/[]/target/review_package/sha256,signoffs/[]/target/direction/sha256,versions/[]/built_with/@rig-c/parts,versions/[]/review_package/files/[]/sha256,versions/[]/outputs/[]/sha256,versions/[]/provenance/config/sha256,versions/[]/provenance/direction/sha256templates/example-draft/derived/drafts/lantern/out/run.jsonpackage/versiontemplates/example-draft/derived/review/v1/out/rig/run.jsonpackage/versiontemplates/example-draft/derived/review/v2/out/rig/run.jsonpackage/versiontemplates/example-draft/evidence/direction-input-v4.jsonscene/sha256templates/example-draft/evidence/direction/v4.jsonscene/sha256templates/example-draft/evidence/scene/s1.jsonrig/acceptance/review_package/sha256templates/example-draft/out/run.jsonpackage/versiontemplates/example-draft/outputs/v1/out/rig/run.jsonpackage/versiontemplates/example-draft/outputs/v2/out/rig/run.jsonpackage/versiontemplates/example-project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,scenes/[]/sha256,signoffs/[]/target/review_package/sha256,signoffs/[]/target/direction/sha256,versions/[]/built_with/@rig-c/parts,versions/[]/review_package/files/[]/sha256,versions/[]/outputs/[]/sha256,versions/[]/provenance/config/sha256,versions/[]/provenance/direction/sha256templates/example-remesh/derived/drafts/remesh/out/run.jsonpackage/versiontemplates/example-remesh/derived/review/v1/out/rig/run.jsonpackage/versiontemplates/example-remesh/derived/review/v2/out/rig/run.jsonpackage/versiontemplates/example-remesh/derived/review/v3/out/rig/run.jsonpackage/versiontemplates/example-remesh/evidence/captions.jsoninputs/project/sha256templates/example-remesh/evidence/direction-input-v4.jsonscene/sha256templates/example-remesh/evidence/direction-input-v5.jsonscene/sha256templates/example-remesh/evidence/direction/v4.jsonscene/sha256templates/example-remesh/evidence/direction/v5.jsonscene/sha256templates/example-remesh/evidence/scene/s1.jsonrig/acceptance/review_package/sha256templates/example-remesh/evidence/v1/registration/package-lock.jsonpackages/node_modules/@rig-c/parts/versiontemplates/example-remesh/evidence/v2/registration/package-lock.jsonpackages/node_modules/@rig-c/parts/versiontemplates/example-remesh/evidence/v3/registration/package-lock.jsonpackages/node_modules/@rig-c/parts/versiontemplates/example-remesh/outputs/v1/out/rig/run.jsonpackage/versiontemplates/example-remesh/outputs/v2/out/rig/run.jsonpackage/versiontemplates/example-remesh/outputs/v3/out/rig/run.jsonpackage/versiontemplates/example-remesh/package.jsondependencies/@rig-c/partstemplates/example-remesh/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,scenes/[]/sha256,signoffs/[]/target/review_package/sha256,signoffs/[]/target/direction/sha256,versions/[]/built_with/@rig-c/parts,versions/[]/outputs/[]/bytes,versions/[]/outputs/[]/sha256,versions/[]/registration/copied/bytes,versions/[]/registration/files/[]/sha256,versions/[]/registration/toolchain/source/bytes,versions/[]/registration/toolchain/source/sha256,versions/[]/review_package/files/[]/sha256,versions/[]/provenance/config/sha256,versions/[]/provenance/direction/sha256templates/example-reopened/project.jsondrafts/[]/files/[]/sha256,drafts/[]/producer/version,interview/question_set,scenes/[]/sha256,signoffs/[]/target/review_package/sha256,signoffs/[]/target/direction/sha256,versions/[]/built_with/@rig-c/parts,versions/[]/review_package/files/[]/sha256,versions/[]/outputs/[]/sha256,versions/[]/provenance/config/sha256,versions/[]/provenance/direction/sha256templates/example-split/captions.jsoninputs/project/sha256tests/fixtures/collection-pin.jsoncollection/interview/question_settests/fixtures/correction-api-path/parts/project.jsoninterview/question_settests/fixtures/correction-api-path/post/project.jsoninterview/question_settests/fixtures/correction-api-path/rig/evidence/feedback.jsonfeedback/[]/context/applied/patch/producer/version,feedback/[]/context/applied/patchSha256,feedback/[]/context/applied/producer/versiontests/fixtures/correction-api-path/rig/evidence/preview.jsonproducer/versiontests/fixtures/correction-api-path/rig/evidence/review-reads/dcfbc20ebb65010fa45dd191606afb5a2076d09333c48cc0a1c3be69e5d84cad.jsonReplacement review-read receipt: producer.version, dependent hashestests/fixtures/correction-api-path/rig/project.jsoncorrections/[]/artifact/feedback/file/path,corrections/[]/artifact/feedback/file/sha256,corrections/[]/artifact/review_read/stdout/path,corrections/[]/artifact/review_read/stdout/sha256,interview/question_set,versions/[]/review_origin/applied/patch/producer/version,versions/[]/review_origin/applied/patchSha256,versions/[]/review_origin/applied/producer/version,versions/[]/review_origin/feedback/path,versions/[]/review_origin/feedback/sha256,versions/[]/review_origin/review_read/stdout/path,versions/[]/review_origin/review_read/stdout/sha256tests/fixtures/correction-api-path/rig/evidence/review-reads/1828ea2fad652da80045fccfb40f9959ef7a1d792e3546ad72003626ed8d6ed3.json