fix: workspace view search param collides with explore view=pivot and blanks the editor - #9895
Merged
Merged
Conversation
… and blanks the editor Explore dashboards previewed inside a file workspace write their own URL state onto the file route, including `view=pivot`/`view=tdd`. The files route consumed that as the workspace view, persisted it to localStorage, and the explore workspace then rendered neither the code editor nor the preview. - Rename the workspace view search param to `editor`. - Only accept known workspace views from the param and from localStorage. - Treat any non-"code" view in ExploreWorkspace as the preview so stale persisted values self-heal.
AdityaHegde
approved these changes
Sep 16, 2026
…rop `split` - Remove the unused `split` view from the type and the allowlist. - CanvasWorkspace falls back to the preview for views it cannot render, matching ExploreWorkspace; correct the comments to say the allowlist is the union across workspaces and each workspace coerces. - Isolate the workspace-stores spec from the module-level singleton.
nishantmonu51
deleted the
nishant/fix-workspace-view-param-collision
branch
September 16, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an explore file sometimes rendered neither the code editor nor the preview, with no console or network errors. The workspace body was empty because the persisted workspace view was
pivot.view=pivot/view=tdd. The files route'sconsumeViewSearchParamtreated that as the workspace view, persisted it to localStorage, andExploreWorkspacehas no branch for it. The bad value survived reloads and restarts until the header toggle was clicked.viewtoeditorso it cannot collide with the explore's ownviewparam. All links go throughgetFileHref, so no other call sites change.ExploreWorkspacenow treats any non-codeview as the preview, so users who already have a stalepivot/tddvalue stored recover on next load.workspace-stores.spec.tscovering the localStorage fallback and the param handling.Repro before the fix: open an explore file, switch to the visual editor, click "Start Pivot", then reload or navigate away and back.
Closes APP-934
Checklist: