Repository navigation
Add CDI editor widget and finish CDI XML parser - #10
Merged
Merged
Conversation
The CDI parser under GUI/lcc/cdi/ was mostly stubs: only <identification> was ever parsed, string/eventid/map parsing were no-ops, and the segment and group token loops silently dropped every other XML token due to a shadowed loop variable that called readNext() twice per iteration. Finish the parser (segment/group/int/string/eventid/map, including self-closing elements like <acdi/> and padding <group offset='n'/>) and add the missing accessors needed to consume the parsed tree. Add CdiEditorWidget, which lets the user pick a CDI XML file and generates a tree/form GUI from it: a tree of segments and groups (with replicated groups expanded into numbered entries), and a right-hand form with a line edit per string, a combo box per mapped int, a spin box per plain int, and a placeholder line edit per event ID. This is GUI generation only - reading/writing the actual node configuration memory is not implemented yet. Wired up as a new "CDI Editor..." entry under the LCC menu. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDI parser under GUI/lcc/cdi/ was mostly stubs: only
was ever parsed, string/eventid/map parsing were no-ops, and the segment and group token loops silently dropped every other XML token due to a shadowed loop variable that called readNext() twice per iteration. Finish the parser (segment/group/int/string/eventid/map, including self-closing elements like and padding ) and add the missing accessors needed to consume the parsed tree.
Add CdiEditorWidget, which lets the user pick a CDI XML file and generates a tree/form GUI from it: a tree of segments and groups (with replicated groups expanded into numbered entries), and a right-hand form with a line edit per string, a combo box per mapped int, a spin box per plain int, and a placeholder line edit per event ID. This is GUI generation only - reading/writing the actual node configuration memory is not implemented yet. Wired up as a new "CDI Editor..." entry under the LCC menu.