Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #152
The addons are needed to support SourceMaps do not change WASM part. The remapping can be done outside the library but needs few small fixes to be implemented in non-hacky way.
Engine
One thing is that engine adds preamble of built-ins, and those have newlines that is not possible to discern without probing by running a small script that throws and inspecting it. That is not science fiction to do, but is engine can provide this info makes integration straight forward to do.
Since stderr and stdout getters are named like that, this code follows the convention.
Engine gets a field:
preambleLineCountand getterpreambleLineCount()that integration can use to reduce reported line number by before going int the SourceMap.I agree with one more addition suggested by LLM in the engine:
It is generally useful for users to be able to reset these before reuse of the engine, and simplifies my sample integration I am using to test for my usage of quickjs4j down the line.
Runner
Runner just forwards
preambleLineCount()andresetOutput().Tests
Tests are LLM generated during the prototyping, they look ok.
Conclusion
During this impl I have thought few times about the SourceMap integration and concluded that it is better to be op-in as sourcemap is json so we do not force user into specific JSON lib.