fix init.doc field on translation.json - #1996
Open
HazizCISSE wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm translating SeleniumLibrary in french with robotframework-seleniumlibrary-translation.
There is an issue on the json translation file generated by the command : "selib translation robotframework_seleniumlibrary_translation/translation_xx.json".
The init.doc field contains the same text as intro.doc field. So when you generate a html documentation with libdoc command : "python3 -m robot.libdoc "SeleniumLibrary::language=fr" selenium_xxx.html".
The generated file contains the introduction twice : once in "introduction" section and in "importing" section.
I'v tried this modification on SeleniumLibrary and it worked :
on line 48 of "SeleniumLibrary/entry/translation.py" :
old : inspect.getdoc(selib)
new : inspect.getdoc(selib.init )
The generated json contains the right text in init.doc field and the html documentation introduction section is ok.