feat: migrate from setup.py to uv for dependency management - #40
Open
skyegalaxy wants to merge 5 commits into
Open
skyegalaxy wants to merge 5 commits into
skyegalaxy wants to merge 5 commits into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Member
Author
|
tried it out on ros2/rmw_dds_common#91 (comment) from a fresh clone off this branch |
mjcarroll
reviewed
Sep 11, 2026
mjcarroll
reviewed
Sep 11, 2026
Member
|
this needs a rebase |
added 4 commits
September 12, 2026 11:44
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
skyegalaxy
force-pushed
the
skyegalaxy/add-uv-support
branch
from
September 12, 2026 18:52
ab2e56c to
6f962a7
Compare
Member
Author
done |
fujitatomoya
approved these changes
Sep 13, 2026
fujitatomoya
left a comment
Contributor
There was a problem hiding this comment.
lgtm with one minor comment.
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #38
Eliminates the need for each developer to setup and run these scripts in their own venv, or on host-managed python, by migrating off of setuptools and towards uv for managing python package installation.
Added a new bootstrapping script
ros-ci-setup-venv:ros-ci-for-pr,ros-find-restarted-ci, andros-github-contribution-reporton the systemPATHin a uv-managed environmentSwitched to uv:
setup.pyandsetup.cfgwithpyproject.tomluv.lockflake8config ontotox.iniandmypyconfig totool.mypyVersion bumps:
PyGithubto>=1.58==0.3.17>=3.9