Repository navigation
chore: remove FORCE_COLOR workaround for Rstest - #112
Merged
chenjiahan merged 1 commit intoSep 28, 2026
Merged
Conversation
Upgrade rstack to ^0.8.0 so tests run on @rstest/core 0.12.2, which no longer injects FORCE_COLOR into test workers, and drop the env override.
chenjiahan
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rstest used to inject
FORCE_COLOR=1into test worker processes (on a TTY or withCI=true), sostyleTextinmakeCodeFrame/displayCodePointerproduced ANSI codes and broke the plain-text snapshots. Theenv: { FORCE_COLOR: '0' }test config was added to work around that.Since
@rstest/core0.12.2 (web-infra-dev/rstest#1893), Rstest no longer writes any color env into workers.Changes
rstackfrom^0.7.4to^0.8.0.rstack0.7.4 pins@rstest/core0.11.12; 0.8.0 resolves@rstest/core0.12.2.define.testblock, whose only option was theFORCE_COLORoverride.With
CI=true, all tests pass without the override. On@rstest/core0.12.1, the two snapshots intest/helpers.test.tsfail without it.