STO-446: feat(model): add --delete-my-model-files-after-upload - #333
Merged
jebenexer merged 1 commit intoSep 2, 2026
Conversation
STO-446: runpodctl model add --model-path re-uploads whatever files currently sit in the directory, with no tracking of what belonged to a previous version. Reusing the same local directory across model versions silently uploads a contaminated mixture of old and new files. Add an opt-in --delete-my-model-files-after-upload flag that removes exactly the files uploaded by this run, but only after the model version hash is confirmed server-side (requires --wait-for-hash). Hash-confirmation failure or a partial delete both return a non-zero exit with nothing silently dropped.
rutvik-runpod
approved these changes
Sep 2, 2026
jebenexer
deleted the
benjaminbrannaka/sto-446-needs-to-automatically-wipe-before-bringing-new-model-in
branch
September 2, 2026 18:44
Promptless documentation updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes STO-446.
model add --model-pathuploads whatever files are currently in the directory, with no tracking of what belonged to a previous version. Reusing the same local directory across model versions silently uploads a contaminated mixture of old and new files.Fix
New opt-in flag:
--delete-my-model-files-after-upload.--model-pathand--wait-for-hash— errors immediately (before any upload) if either is missing.deletedModelFiles/deletedModelFilesBytesto JSON output.Testing
config.jsonsilently included it — confirmed by downloading the file and seeing model A's content.Follow-up (not in this PR)
The
runpodctlskill and vendoredcommand-surface.jsoninrunpod/runpod-plugins-officialare both tied to released versions — will update those once this ships in a release.