Skip to content

Fix VTR viewed-map flush after reload - #956

Open
MhaWay wants to merge 2 commits into
rwmt:devfrom
MhaWay:analysis/pr-865-projectile-desync
Open

MhaWay wants to merge 2 commits into
rwmt:devfrom
MhaWay:analysis/pr-865-projectile-desync

Conversation

@MhaWay

@MhaWay MhaWay commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Fix VTR viewed-map flush after reload

This prevents viewed-map updates from being dropped during reload transitions, which left VTR/player-count state incoherent and caused the projectile slowdown symptom.

Validation:

  • Release build succeeded on the fix branch
  • Dev-port build succeeded and reproduced the issue/fix path

Copilot AI review requested due to automatic review settings June 28, 2026 15:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a multiplayer reload edge case where viewed-map (PlayerCount) updates could be dropped during Multiplayer.reloading transitions, leaving player-count/VTR state inconsistent and contributing to the reported projectile slowdown symptom.

Changes:

  • Queue viewed-map updates during reload instead of dropping them.
  • Add a flush mechanism and invoke it from several frequently-hit patches to ensure pending updates are delivered once reload completes.
  • Reset pending viewed-map state alongside existing VTR sync state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Source/Client/Patches/VTRSyncPatch.cs
@Zetrith

Zetrith commented Jun 28, 2026

Copy link
Copy Markdown
Member

This just brings back #862 which #865 was supposed to fix

@MhaWay

MhaWay commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

This just brings back #862 which #865 was supposed to fix

Not yet tested that, I'll do ad soon as possible

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MhaWay

MhaWay commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Im back at it and found the issue, is related to the update of the player count, in fact, the issue is that the projectiles get updated every new refresh(every 15 tick/0.3s) and so it gets freezed and updated every tot time. Get out in the world map and re entering the map fix the issue, soo the issue is related to the player count on the map who gets pulled to 0.

Going to upload the new code as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants