feat(model): Model.model_runs() — list a model's run ids - #478
Open
luke-e-schaefer wants to merge 1 commit into
Open
feat(model): Model.model_runs() — list a model's run ids#478luke-e-schaefer wants to merge 1 commit into
luke-e-schaefer wants to merge 1 commit into
Conversation
The model-scoped counterpart to Dataset.model_runs(): lists every run under a model via GET /nucleus/model/:modelId/modelRun. include_versions=True unions runs across the model's version lineage (?family=true). Results are dataset-scoped server-side. Adds a mock unit test, CHANGELOG entry, and version bump to 0.21.3. Requires the matching scaleapi route (scaleapi#158386); live calls 404 until it deploys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
luke-e-schaefer
marked this pull request as ready for review
August 31, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Model.model_runs()— the model-scoped counterpart toDataset.model_runs(), which only lists a single dataset's runs. Hits the newGET /nucleus/model/:modelId/modelRunroute.nucleus/model.py— newmodel_runs(include_versions=False) -> List[str], delegates tomake_request({}, "model/{id}/modelRun", requests.get)(mirrorsDataset.model_runs).tests/test_model_runs_listing.py— mock unit tests: returns the ids / hits the right route, andinclude_versions=Trueappends?family=true.0.21.3+pyprojectversion bump.Test Plan
pytest tests/test_model_runs_listing.py→ 2 passed.black/isortclean.Server dependency
Pairs with scaleapi#158386 (
GET /nucleus/model/:modelId/modelRun).🤖 Generated with Claude Code
Greptile Summary
Adds a model-scoped API for listing run IDs, with optional inclusion of runs across the model’s version lineage. The change also adds focused route tests and releases the API as version 0.21.3.
Model.model_runs(include_versions=False).family=truewhen version-lineage runs are requested.Confidence Score: 5/5
The PR appears safe to merge, with no concrete client-side defects identified in the new model-run listing path.
The route construction, GET delegation, optional lineage query, return contract, tests, documentation, and package version are internally consistent.
Important Files Changed
Reviews (1): Last reviewed commit: "feat(model): add Model.model_runs() to l..." | Re-trigger Greptile
Context used (3)