Repository navigation
Conversation
I noticed the `ITA.py` module has the deprecated method `ITA.ITA_collection.stitch_correction()` which imported ```shell from scipy.ndimage.filters import gaussian_filter ``` This is deprecated... ```shell DeprecationWarning: Please import `gaussian_filter` from the `scipy.ndimage` namespace; the `scipy.ndimage.filters` namespace is deprecated and will be removed in SciPy 2.0.0. ``` This has already been corrected in other places of the `pySPM` code base but not in the ITA import... ``` (.venv) ❱ rg gaussian_filter . ./pySPM/align.py 12:from scipy.ndimage import gaussian_filter 185: im1 = gaussian_filter(Ref, gauss) 186: im2 = gaussian_filter(Img, gauss) 259: im1 = gaussian_filter(Ref, gauss) 260: im2 = gaussian_filter(Img, gauss) ./pySPM/SPM.py 1591: self.pixels = scipy.ndimage.gaussian_filter( 1596: C.pixels = scipy.ndimage.gaussian_filter(C.pixels, sigma=sigma, **kwargs) ./pySPM/ITA.py 1140: from scipy.ndimage.filters import gaussian_filter 1153: S = gaussian_filter(S, gauss) ``` The method itself is marked as being deprecated but figured there was no harm in updating it in case people still use it.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the
ITA.pymodule has the deprecated methodITA.ITA_collection.stitch_correction()which importedThis is deprecated...
This has already been corrected in other places of the
pySPMcode base but not in the ITA import...The method itself is marked as being deprecated but figured there was no harm in updating it in case people still use it.