Repository navigation
fix(auth): send the pairing token on GetLogs and TailLogs (2.8.1) - #196
Merged
Merged
Conversation
OPEN_METHODS still listed GetLogs and TailLogs from when the device left logs open, so the interceptor sent them without a token. The device gates them, so every log read from a paired client was refused as "not paired" (synapsectl logs; etester's inference checks, which poll GetLogs). The set is now exactly the device's open list, Info and RequestAuth, pinned by a test. Version 2.8.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
synapse-python 2.8.0 sends
GetLogsandTailLogswithout the pairing token, so against SciFi firmware with device pairing every log read from a paired client is refused with "not paired with this device". That breakssynapsectl logsand anything that polls logs, e.g. the headstage echo-ciinference_capabilities.py, which waits for the app's verdict viaGetLogs.Cause:
OPEN_METHODSinsynapse/client/auth.pystill listedGetLogsandTailLogsfrom when the device left logs open. The device's open list (src/auth/rpc_auth_policy.cpp,kOpenMethods) is onlyInfoandRequestAuth; logs were gated later.Changes
OPEN_METHODSis now exactlyInfoandRequestAuth, so the interceptor attaches the token to log calls like every other gated RPC.OPEN_METHODSto the device's list, and checks the log RPCs carry the token.Testing
pytest: 210 passed.GetLogspoll frominference_capabilities.pyfailed with "not paired with this device". Re-running it on 2.8.1 is the end-to-end check.Release
After merge:
git tag v2.8.1 origin/main && git push origin v2.8.1.