Interface SCIP methods - #1237
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
- Coverage 57.91% 57.29% -0.62%
==========================================
Files 26 27 +1
Lines 5807 5936 +129
==========================================
+ Hits 3363 3401 +38
- Misses 2444 2535 +91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Sorry for the delay @adamj34 ! I'm not as free in September as I was expecting to be, but I'll still manage to take a closer look. I'm not sure what the code coverage bot is complaining about (am AFK), but it'd be nice to ensure that everything is tested. |
Co-authored-by: João Dionísio <57299939+Joao-Dionisio@users.noreply.github.com>
|
Thank you for your suggestions and comments @Joao-Dionisio! I believe I've addressed all of them. If there's anything that requires further improvement, then let me know. Regarding the Codecov complaints, I double checked if all methods that I added were tested. It seems that PS I hope that these reviews aren't taking too much time away from your PhD 😊 |
|
Thank you! We're really in the final stages, less than a month to go, thankfully 🙏 |
Joao-Dionisio
left a comment
There was a problem hiding this comment.
Thank you @adamj34 , and sorry for the long review process! Keep 'em coming 😁
Adds the following methods:
getNNodesLeft(),getNRuns(),getNReoptRuns(),addNNodes(),getDeterministicTime(),getAvgDualbound(),getMaxTotalDepth(),getNBacktracks(),getFocusNode(),getAvgLowerbound(),getFirstPrimalBound(),getLowerboundRoot(),getUpperbound(),getNObjlimLeaves()Adds tests in
tests/test_statistics.pyandtests/test_node.pyfor migrated methodsAdds function signatures to
scip.pyifor type hintsUpdates
CHANGELOG.md