Skip to content

Interface SCIP methods - #1237

Merged
Joao-Dionisio merged 20 commits into
scipopt:masterfrom
adamj34:interface
Sep 15, 2026
Merged

Joao-Dionisio merged 20 commits into
scipopt:masterfrom
adamj34:interface

Conversation

@adamj34

@adamj34 adamj34 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Adds the following methods:
getNNodesLeft(), getNRuns(), getNReoptRuns(), addNNodes(), getDeterministicTime(), getAvgDualbound(), getMaxTotalDepth(), getNBacktracks(), getFocusNode(), getAvgLowerbound(), getFirstPrimalBound(), getLowerboundRoot(), getUpperbound(), getNObjlimLeaves()

Adds tests in tests/test_statistics.py and tests/test_node.py for migrated methods

Adds function signatures to scip.pyi for type hints

Updates CHANGELOG.md

Comment thread src/pyscipopt/scip.pyi Outdated
@adamj34
adamj34 marked this pull request as ready for review July 25, 2026 19:46
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.29%. Comparing base (9547994) to head (2587c2c).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/pyscipopt/scip.pxi 50.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
- Coverage   57.91%   57.29%   -0.62%     
==========================================
  Files          26       27       +1     
  Lines        5807     5936     +129     
==========================================
+ Hits         3363     3401      +38     
- Misses       2444     2535      +91     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/pyscipopt/scip.pxi Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread src/pyscipopt/scip.pxi
Comment thread tests/test_statistics.py Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread CHANGELOG.md Outdated
@Joao-Dionisio

Joao-Dionisio commented Sep 1, 2026

Copy link
Copy Markdown
Member

Sorry for the delay @adamj34 ! I'm not as free in September as I was expecting to be, but I'll still manage to take a closer look.

I'm not sure what the code coverage bot is complaining about (am AFK), but it'd be nice to ensure that everything is tested.

adamj34 and others added 3 commits September 1, 2026 17:49
Co-authored-by: João Dionísio <57299939+Joao-Dionisio@users.noreply.github.com>
Comment thread tests/test_statistics.py Outdated
@adamj34
adamj34 marked this pull request as draft September 1, 2026 18:58
Comment thread tests/test_statistics.py Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread src/pyscipopt/scip.pxi Outdated
Comment thread tests/test_statistics.py Outdated
Comment thread tests/test_statistics.py
@adamj34
adamj34 marked this pull request as ready for review September 3, 2026 15:44
@adamj34

adamj34 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for your suggestions and comments @Joao-Dionisio!

I believe I've addressed all of them. If there's anything that requires further improvement, then let me know.

Regarding the Codecov complaints, I double checked if all methods that I added were tested. It seems that getFocusNode was only indirectly tested in test_getAvgLowerbound, so I added a dedicated test for it in e1caacd. Beyond that, I think that all methods have an accompanying test.

PS I hope that these reviews aren't taking too much time away from your PhD 😊

@Joao-Dionisio

Copy link
Copy Markdown
Member

Thank you! We're really in the final stages, less than a month to go, thankfully 🙏

Comment thread tests/test_statistics.py Outdated

@Joao-Dionisio Joao-Dionisio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamj34 , and sorry for the long review process! Keep 'em coming 😁

@Joao-Dionisio
Joao-Dionisio enabled auto-merge (squash) September 15, 2026 16:23
@Joao-Dionisio
Joao-Dionisio merged commit 7bf4b15 into scipopt:master Sep 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants