Skip to content

SDV 2.0: The download_demo function should return the right metadata - #2977

Open
R-Palazzo wants to merge 4 commits into
v2.0.0from
issue-2956-download-demo-right-metadata
Open

SDV 2.0: The download_demo function should return the right metadata#2977
R-Palazzo wants to merge 4 commits into
v2.0.0from
issue-2956-download-demo-right-metadata

Conversation

@R-Palazzo

@R-Palazzo R-Palazzo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Resolve #2956
86bbgk6rf

@R-Palazzo R-Palazzo self-assigned this Sep 4, 2026
@R-Palazzo
R-Palazzo requested a review from a team as a code owner September 4, 2026 09:21
@sdv-team

sdv-team commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@codecov

codecov Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (9e23c92) to head (d92ef8f).

Additional details and impacted files 
@@           Coverage Diff           @@
##           v2.0.0    #2977   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          66       66           
  Lines        7684     7686    +2     
=======================================
+ Hits         7521     7523    +2     
  Misses        163      163
Flag Coverage Δ
integration 83.95% <100.00%> (+<0.01%) ⬆️
unit 96.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sarahmish
sarahmish approved these changes Sep 4, 2026
View reviewed changes
Comment thread sdv/datasets/demo.py Outdated
@sdv-team

sdv-team commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@R-Palazzo
R-Palazzo force-pushed the issue-2956-download-demo-right-metadata branch from 6e01094 to d92ef8f Compare September 7, 2026 10:18
@sdv-team

sdv-team commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This Pull Request is not linked to an issue. To ensure our community is able to accurately track resolved issues, please link any issue that will be closed by this PR!

@R-Palazzo
R-Palazzo requested review from pvk-developer and removed request for pvk-developer September 10, 2026 09:01
rwedge
rwedge reviewed Sep 10, 2026
View reviewed changes
Comment thread tests/integration/datasets/test_demo.py
download_demo(modality='multi_table', dataset_name='adventure-works')


def test_download_demo_raise_warning_v2_metadata():

@rwedge rwedge Sep 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going to happen to this test when we update the demo datasets to have V2 metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwedge rwedge rwedge approved these changes
@sarahmish sarahmish sarahmish approved these changes

Assignees

@R-Palazzo R-Palazzo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@R-Palazzo @sdv-team @rwedge @sarahmish