Repository navigation
feat: Omit Knex types when generate_knex_types is false - #22
Merged
Merged
Conversation
generated/utils.ts always imported `knex` and declared KnexTable, and each schema index always imported KnexTable, even with generate_knex_types false. Emit them only when generate_knex_types is true; output for true is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: with
generate_knex_types: false,generated/utils.tsstill emittedimport { Knex } from "knex",KnexInsertableTableandKnexTable, and eachgenerated/<schema>/index.tsstill importedKnexTable. Consumers withoutknexinstalled failed to typecheck.Fix: emit those only when
generate_knex_types === true. Output fortrueis byte-for-byte unchanged.This unblocks removing Knex from seam-connect (seamapi/seam-connect#18298) and lets that PR drop its post-processing workaround.
🤖 Generated with Claude Code