chore(seidroid-review): take driver v0.17.0 - #104
Conversation
The `driver-version` default and the version floor move together, which the floor's own comment requires: a caller may run ahead of the default, never behind it. v0.17.0 publishes `supersedes` per finding in findings.json -- the prior threads that finding replaces. The resolve step reads it to close each superseded thread only once that finding's own replacement reached the code. On v0.15.0 or v0.16.0 the field is absent, the step reports superseded_linked=false and falls back to its per-review gate, so a review superseding three threads closes all three on the strength of one unrelated finding placing. The floor also crosses v0.16.0, which bounds the prior-thread history by bytes rather than by a count of twenty threads and three replies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PR SummaryLow Risk Overview Documentation in the workflow is updated to match: Reviewed by Cursor Bugbot for commit 8eb907b. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
A clean, well-scoped bump of both the driver-version default and MIN_DRIVER_VERSION from v0.15.0 to v0.17.0, moved together as the file's own comment requires, with the prose and the version ladder updated to match. Only finding is a stray line break left by an incomplete comment rewrap.
Findings: 0 blocking | 2 non-blocking | 1 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- The floor and the
driver-versiondefault move together as the comment at.github/workflows/seidroid-review.yml:1347requires, and all four prose mentions of the installable version (lines 106 twice, 1369) are consistent atv0.17.0. The two remainingv0.15.0mentions are contrastive entries in the version ladder and stay correct. No in-repo caller passesdriver-version, and no test asserts a version string, so nothing here breaks. Consumers in other repos that pindriver-version: v0.15.0will hard-fail at install once they bump theiruses:sha — the PR body already records this on PLT-1165/1170/1174, which is the right place for it since this repo cannot enforce it. - 1 suggestion(s)/nit(s) flagged inline on specific lines.
| # history by bytes where v0.15.0 bounds it by a count; and v0.17.0 names which | ||
| # thread each finding replaces, which is what lets the resolve step below close | ||
| # a thread only once its own replacement reached the code. A merge gate keyed | ||
| # on one of |
There was a problem hiding this comment.
[nit] Incomplete rewrap: # on one of is left as a three-word line dangling between two full-width ones, and line 1343 ends mid-clause (A merge gate keyed). Reflowing 1343-1345 into two full lines would keep this block reading as prose, which matters more than usual in a file where these comments are the documentation.
There was a problem hiding this comment.
Fixed in 8eb907b. The rewrap was mine and it was sloppy: # on one of dangling between two full-width lines, with the line above ending mid-clause at A merge gate keyed.
Reflowed to two lines. Widths across the block now run 84-90 with the closing # rest. — no dangling fragment, and the sentence reads through.
You are right that it matters more here than usual. These comments are this file's documentation, and a reader who hits a three-word line assumes something was cut.
Four harnesses re-run on the reflow: 271, 241, 77, 77, all zero failed. actionlint unchanged at 4× SC2102.
The v0.17.0 line left `# on one of` dangling between two full-width lines, with the line above ending mid-clause. These comments are this file's documentation, so the block has to read as prose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
A version-only bump of the review driver from v0.15.0 to v0.17.0, moving the driver-version default and MIN_DRIVER_VERSION together as the floor's own comment requires, with the version ladder and both go install prose examples updated to match. No in-repo caller pins driver-version, the floor comparison handles the new value correctly, and the supersedes consumer this bump activates is already present and degrades safely — nothing to flag.
Findings: 0 blocking | 0 non-blocking | 0 posted inline
Blockers
- None at the file/PR level.
Non-blocking
- None at the file/PR level.
Two literals moved together, as the floor's own comment requires:
driver-version's default andMIN_DRIVER_VERSION, bothv0.15.0→v0.17.0. A caller may run ahead of the default, never behind it.Why now
v0.17.0publishessupersedesper finding — the prior threads that finding replaces. The resolve step reads it to close each superseded thread only once that finding's own replacement reached the code.On
v0.15.0orv0.16.0the field is absent, so the step reportssuperseded_linked=falseand falls back to its per-review gate: a review superseding threads A, B and C closes all three on the strength of one unrelated finding placing. The per-thread gate shipped in #102 is inert until this lands.The floor also crosses
v0.16.0, which bounds the prior-thread history by bytes rather than by a count of twenty threads and three replies — the same budget that carries 645 one-line findings where the count carried 20.Also updated
The
MIN_DRIVER_VERSIONcomment's version ladder, which contrasts what each release concludes or carries. It now runs tov0.17.0. The two remainingv0.15.0mentions are both in that ladder, as contrasts, and stay true.Both
go installexamples in the prose now namev0.17.0.What this refuses
Any caller pinning below
v0.17.0fails at install with a named message rather than mid-review. Both callers pinuses:by sha and still run an older workflow, so nothing breaks today — but each cutover must drop itsdriver-versionline in the same commit that bumps itsuses:sha. Recorded on PLT-1165, PLT-1170 and PLT-1174.Verification
Not verified: nothing ran on a GitHub runner. The install step's floor comparison was exercised against real
go installs when it shipped; this change moves its constant and does not touch its logic.