Repository navigation
feat: port can be number - #176
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The home-directory description gives an unsupported default name and contradicts the documented task environment behavior.
1 open issue
What changed in this PR
This PR updates Semaphore UI’s configuration reference to clarify numeric HTTP port values and revise task home-directory documentation.
Changes:
- Documents port values with or without a leading colon, including unquoted numbers.
- Revises the
home_dir_modedescription for task directories and Ansible isolation.
| File | Description |
|---|---|
docs/reference/configuration.md |
Updates the port and home-directory configuration descriptions. |
Review effort: Balanced
| | `tmp_path`<br />`SEMAPHORE_TMP_PATH` | string<br />Default: `/tmp/semaphore` | semaphore stores ephemeral projects here | | ||
| | `secrets_path`<br />`SEMAPHORE_SECRETS_PATH` | string | Legacy top-level setting for backwards compatibility. Users should prefer configuring dirs.secrets instead. | | ||
| | `home_dir_mode`<br />`SEMAPHORE_HOME_DIR_MODE` | string<br />Default: `template_dir` | Controls how the HOME environment variable is set for tasks. "template_dir" (default) — HOME is not overridden (keeps the HOME of the server or runner process). Ansible tasks get ANSIBLE_HOME set to a per-template "_home/.ansible" directory under the project temp directory, isolating .ansible/ across parallel tasks. "project_home" — HOME is set to the project temp directory (legacy behavior). Parallel ansible-galaxy runs in the same project may conflict. "user_home" — HOME is not overridden (keeps the real user HOME) and ANSIBLE_HOME is not set. One of `user_home`, `project_home`, `template_dir`. | | ||
| | `home_dir_mode`<br />`SEMAPHORE_HOME_DIR_MODE` | string<br />Default: `template_dir` | Controls how the HOME environment variable is set for tasks. "template_home" (default) — HOME is set to a per-template directory, isolating .ansible/ across parallel tasks. Repo is cloned into a "src" subdirectory under HOME. "project_home" — HOME is set to the project temp directory (legacy behavior). Parallel ansible-galaxy runs in the same project may conflict. "user_home" — HOME is not overridden (keeps the real user HOME). ANSIBLE_HOME is set per template to isolate .ansible/ for Ansible tasks. One of `user_home`, `project_home`, `template_dir`. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.