Repository navigation
CPLAT-12785: async tmux leftovers and keymap-derived footers/help - #176
Merged
Merged
Conversation
Pane jump (incl. live resume and ctrl+g), live preview open, bulk input and share-ref now resolve panes in a tea.Cmd; results carry a generation and Update drops superseded ones. The backslash continuation and bulk sends report send-keys errors instead of discarding them.
…ap table bindings.go adds a label/help table over every Keymap field. Footers, menu footers, the session actions hint box and the ? overlay read keys and labels from it, so a keys override changes every surface at once. Footers drop low-priority hints with an ellipsis when narrow and pin help/quit. Stats/config/plugins dispatch now uses the keymap for the keys their footers advertise, and Left/Right/resize overrides reach the split pane. Fixes the state menu footer that said S while the key is s. Adds Conflicts() and reachability tests.
Kairo-Kim
approved these changes
Oct 14, 2026
mitrilmad
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://sendbird.atlassian.net/browse/CPLAT-12785
Summary
Follow-up to #175. Two changes:
?help.Changes
Async tmux (
tmux_async.go)FindPaneand switch-client in atea.Cmd: pane jump, live resume,ctrl+gin the live preview, opening the live preview, bulk input, and share-ref..Run()errors: the\continuation (now onesendKeys) and bulk sends (nowerrors.Join). Both now report the error in the status line.Binding table (
bindings.go)Keymapfield with a footer label and help text. Keys still come fromKeymap, which keeps the existing yaml overrides.footer()keeps hints in priority order. When the line is narrow, it drops unpinned hints from the end and shows…. Help and quit stay pinned, and so doesescin the conversation view.?common and session-list rows.q,escandp, and config/pluginsx.Left,Rightand resize overrides now reach the split pane throughresolveSplitKey.scopeKeysnow reads from the table.S:states, but the key iss.Tests
tmux_async_test.go. It checks that no tmux call runs on the Update path, that stale results are dropped, and that send errors show up in the status line.bindings_test.go. It covers:Conflicts()?and not swallowed by a global intercept?…with pinned help/quit?and dispatch togethergo vet ./...andgofmt -l .are clean.go test -race -count=1 ./...passes exceptTestDayCursorMoveCost, a frame-budget timing test that also fails under-raceonmaster(about 20 ms per move). It passes without-race, which is how CI runs it.