Repository navigation
[CPLAT-12912] Keyboard-first mouse convention: wheel 3, Clicks, picker mouse, overlay ownership - #178
Merged
Merged
Conversation
- wheel steps 3 (tuikit mouse.WheelRows) instead of 1 - double click uses tuikit mouse.Clicks keyed by item; empty-area clicks never activate - picker (RunPicker) gets mouse: click selects, second click is Enter, wheel moves 3 - every overlay owns the mouse while open: wheel drives scrollable ones, outside click is its Esc - program options come from mouse.ProgramOptions() - bump tuikit to c905dce
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
fe52488 |
2026-10-20 02:39 UTC | 0 | 0 | 0 |
ab53805 < |
2026-10-20 02:59 UTC | 0 | 0 | 0 |
Last scanned: ab53805 · 2026-10-20 02:59 UTC
Codex found on the ccproxy rollout that click, j, k, click on the same row read as a double click and fired Enter, because only mouse presses touched the detector. Reset it in the KeyMsg arm of the app and the picker.
Kairo-Kim
approved these changes
Oct 20, 2026
Kairo-Kim
added
the
auto-review/approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://sendbird.atlassian.net/browse/CPLAT-12912
Brings ccx to the fleet keyboard-first mouse convention. The existing mouse.go (split-border drag, list click, viewport wheel, copy-mode scroll) is kept; this closes the gaps.
Changes
mouse.WheelRows), was 1. Applies to lists, previews, fold block cursor and the execution rail.doubleClickThreshold,lastClickY/Time) replaced by tuikitmouse.Clicks, keyed by the clicked item (session ID / list index / preview block). A second click on the same item runs the Enter path; a click on empty rows never counts.RunPicker(urls/files/refs/changes/conversation pickers) now has mouse: click selects (multi-line rows hit viamouse.BlockHit), second click is Enter, wheel moves 3, preview wheel scrolls 3, the ref sub-picker owns the mouse, search line ignores it.Viewand the hit test sharerenderListLines.internal/tui(21 entries inmouseOverlays) owns the mouse while open: scrollable ones follow the wheel via their own up/down keys, others swallow it, a click outside is the overlay's Esc, nothing reaches the base. Overlay bounds are measured fromView(with vs without the overlay) so there is no second copy of the layout math.tea.NewProgramcalls usemouse.ProgramOptions(). tuikit bumped to c905dce.mouse_clicks.go,mouse_overlay.go,internal/cli/picker_mouse.go;app.goonly swaps two fields for one.Not done
Tests
go vet,go test -race, ko_KR locale run,gofmtclean.TestDayCursorMoveCost(a 60fps timing test) failed once when the whole repo ran in parallel under load and passes alone and on rerun; unrelated to this change.Mutations (all compile) and the test that fails: picker scroll offset dropped ->
TestPickerClickRespectsScrollOffset; list page start dropped ->TestClickOnSecondPageSelectsThatRow; overlay rect = whole screen ->TestOverlayOutsideClickClosesAndIsolatesBase/*; wheel step 1 ->TestWheelScrollsFocusedPreviewByThreeLines; overlay wheel falls through ->TestOverlayWheelNeverReachesBaseOrDismisses/config_actions; click key ignores item ->TestSecondClickOnDifferentRowOnlySelects.Security checklist (Infrastructure code)