Repository navigation
feat(review): highlight the code view and keep it readable in any pane width - #820
Merged
Merged
Conversation
- diffLines sets the common head and tail aside before the LCS table, so a one-line edit to a 10,000-line file takes about 2 ms instead of 800 ms and ~860 MB; a changed middle above MAX_LCS_CELLS renders as removed then added. - The line-number gutter is sized by the longest line number (never narrower than 2rem), so four- and five-digit numbers no longer run into each other. - After Expand, focus moves to the first revealed line instead of the body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e width - The diff is syntax highlighted with the shared highlighter, collapses unchanged runs to three lines of context, and has a per-file name. - The file header shows the path, change kind, line counts and rename, stays pinned while the diff scrolls, and never squeezes its comment action. - Switching files starts the diff at its top; the highlighter loads while the scope is read. - Below the stacked breakpoint the layout scrolls instead of clipping the diff after the first screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
astyfx
requested review from
JongSikLim and
paul-seo73
and removed request for
a team
October 24, 2026 17:24
|
| Commit | Scanned at | New | Resolved | Net |
|---|---|---|---|---|
68ad75e < |
2026-10-24 17:24 UTC | 0 | 0 | 0 |
Last scanned: 68ad75e · 2026-10-24 17:24 UTC
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review's code view showed plain text, rendered every unchanged line of a file, and could not be scrolled past the first screen once the pane was narrower than the stacked breakpoint. This makes it read like the chat's file diffs and keeps it usable at any width.
Changes
Review code view (
src/components/review/*)+N −M, "Renamed from …"; it stays pinned while the diff scrolls, and the comment action never shrinks.layoutHost'soverflow: hiddenleft everything past the first screen unreachable; this was the case since feat(review): show the task's run over Review and open side questions there #815.ADS DiffViewer (host-owned copy, recorded in
PROVENANCE.md)diffLinessets the common head and tail aside before the LCS table. A one-line edit to a 10,000-line file takes about 2 ms instead of 804 ms and ~860 MB, with identical output. A changed middle aboveMAX_LCS_CELLSrenders as removed then added.The chat's file diffs share the DiffViewer and highlighter changes.
Verification
bun run build:pages: passedoxlint,bun run typecheck,check:i18n,check:design-system,check:style-channel,check:max-lines-ratchet,check:doc-paths,codebase-structure: all exit 0review-code-view(new),review-while-running,review-entry-points: 13 passed. The three new tests fail when their fixes are reverted (narrow scroll, focus after Expand, unclipped comment label).Not verified: the keyboard focus ring drawn after Expand (focus placement is covered by e2e), and the packaged Electron app.
🤖 Generated with Claude Code