Repository navigation
Conversation
Support CMake 4 when configuring vendored cJSON and usrsctp. Includes: * disable usrsctp warnings-as-errors for newer compilers * search lib64 for dependencies installed (Fedora) Co-authored-by: Codex <codex@openai.com> Co-authored-by: Claude <noreply@anthropic.com>
Mbed TLS 4 handles random generation through PSA. The DTLS-SRTP path already avoids the legacy CTR-DRBG callbacks for cookies and SSL, but still initialized and freed unused entropy and CTR-DRBG contexts. Some Mbed TLS 4 integrations omit those legacy symbols. Guard the unused setup and teardown on pre-4 releases while preserving the existing path for older Mbed TLS versions. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support current CMake and Mbed TLS releases without changing older build paths.
Pass the legacy policy floor to vendored cJSON and usrsctp only when building with CMake 4 or newer.
Disable usrsctp warnings-as-errors for newer compilers.
Search both dist/lib and dist/lib64.
Skip unused entropy and CTR-DRBG initialization and teardown under Mbed TLS 4, while preserving those calls for earlier releases.
Testing
Before: CMake 4.3 failed to configure vendored cJSON and usrsctp because compatibility below CMake 3.5 was removed.
CMake 4.3 with bundled Mbed TLS 4.1: Full build and all five tests passed.
CMake 3.31 with bundled Mbed TLS 4.1: Full build and all five tests passed.
Mbed TLS 3.6.7 DTLS-SRTP compile check passed.