Repository navigation
Conversation
Account for CSRC lists, header extensions, and padding before media depacketization. Reject invalid RTP versions and truncated extension or padding fields before exposing payload bytes. Bound generic payloads and H.264 single-NAL, STAP-A, and FU-A inputs. Reject empty NAL units, oversized fragments, continuation fragments without a start, and trailing incomplete STAP-A data. Add focused regressions for valid extension and padding layouts, malformed lengths, H.264 packetization bounds, and generic payload limits. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Codex <codex@openai.com>
libSRTP can append up to SRTP_MAX_TRAILER_LEN bytes while protecting an RTP packet. The encoder and peer receive path reserved a hard-coded 128 bytes, less than the current libSRTP maximum of 144 bytes. Size both packet buffers from the library constant so a CONFIG_MTU packet can be protected and received without truncating or exceeding storage. Extend the RTP regression with an MTU-spanning H.264 FU-A round trip and assert the shared protected-packet capacity. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate complete RTP packet framing before media depacketization.
Testing