Repository navigation
Fix dshow endgame music - #637
Merged
Merged
Conversation
With AllowDShowSound, gsound_background_stop_ does not stop music played via DirectShow, so map music played over the endgame slides and the credits music kept playing afterwards.
… end callback The endgame credits song looped forever and the music after it never started, since sfall looped all engine music.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref BGforgeNet/Fallout2-HQ-music#9
Neuroslop warning: debugged and fixed with LLM assistance.
I tested the fix, and it works, but I'm not 100% sure it's solid. Please check it out.
With
AllowDShowSound=1:Fixes:
gmovie_play_hook_stopis also hooked at0x43F9B1(endgame_init_) and0x43F813,0x43F886,0x43F89C(endgame_movie_). With sfall playing the music,gsound_background_stop_has nothing to stop.background_loop_requested(0x518E70) is 15, then the callback ingsound_background_callback_fp(0x518E58) is called, as for ACM music. Only akiss is requested this way; its callback letsendgame_movie_bk_process_start 10labone.