Repository navigation
Conversation
|
Accuracy review against the server and CLI code These checked out against the server: oldest-first cursor echo on empty pages, the 60s settle window,
One more fix from the same pass: the sample event was a console action with a browser user agent. Console actions reach the API from the console's servers, so the sample is now a |
|
Pushed 46321e3: the |
…Id skips staff The CLI user agent in the sample isn't sent by any released CLI. Console actions now record the person's IP and browser user agent (_shorebird#3620). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Adversarial review (independent agent with no context from the authoring sessions, at 52d6ef5, checked against _shorebird main, the public CLI source, and docs#733) No factual errors in the event mapping, cursor logic or permissions. Findings:
Checked and correct:
|
Script runs in bash and zsh; what isn't recorded; correlation_uid is the caller's X-Request-ID; sign-in details are flat unmapped keys; deleted service accounts; actor_source can be absent; dates need a zone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review summary. Every claim on the page has been checked against _shorebird main ( From my own pass (52d6ef5)
Adversarial review findings
Open for Eric, not changed: console events recorded before #3620 deploys carry the console server's IP and the user agent |
|
lgtm |
|
Landing status at 7bc77df: CI is green and Eric has LGTM'd. Three things still hold this PR:
I'll merge through the queue once all three hold. |
|
@AbhishekDoshi26 this is ready for your review: the public audit log and SIEM export page. Eric has LGTM'd the content, and the accuracy and adversarial reviews are above, with every finding fixed or answered. It lands after #733 (please review that one too), so the links between the two pages can become relative. |
#733 renamed #issue-and-revoke-keys to #create-and-revoke-keys, and the console now creates a service account with the Developer role first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Enterprise customers can read their organization's audit log in the console and through
GET /organizations/{id}/audit-logs, but nothing in the docs says it exists, who can read it, how to export it to a SIEM without missing events, or what an event looks like. Security teams evaluating Shorebird ask for exactly this.This adds
/account/audit-logs/:order=asc, savingnext_cursor, deduplicating onmetadata.uid, and one sentence on why the newest minute is held back. Examples withcurlandshorebird api.api.operation, actor types including Shorebird staff,actor.sessionand whenis_mfais absent,api.token,src_endpoint,unmapped).It also lists the audit log on the Enterprise page and adds
ocsf,siemandurlencodeto the cspell words.The service account and trust rule pages are in #733. Links to them use absolute
https://docs.shorebird.dev/account/service-accounts/and/account/trust-rules/URLs (as #733 does for this page) so each PR builds on its own. They can become relative links once both land.Landing
After all of:
https://docs.shorebird.dev/account/service-accounts/and/account/trust-rules/links to relative ones, so the link validator checks them._shorebird#3620, #3615 and #3616 are all in prod (#3620 shipped in Deploy All run https://github.com/shorebirdtech/_shorebird/actions/runs/39080022147).
🤖 Generated with Claude Code