fix: skip prompt commit when prompt is undefined - #185
Merged
Merged
Conversation
Debounced generate-toolbar commits wrote `prompt: undefined` when the field was cleared, which fails Zod validation and crashed the host. Skip the clip update for empty prompts; still clear merge bindings.
|
🎉 This PR is included in version 2.19.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clearing or emptying the generate prompt triggered a debounced
updateClipwithprompt: undefined, which fails Zod and crashed the host.Verify
npx jest tests/generate-toolbar.test.tsRisk
Low. Empty prompts no longer persist via
updateClip(generate already no-ops on empty input). Merge-field bindings are still cleared.