fix: surface preview failures with troubleshooting links - #186
Merged
Merged
Conversation
dazzatronus
changed the title
dazzatronus
changed the title
dazzatronus
force-pushed
the
fix/preview-error-help
branch
from
September 15, 2026 11:42
789b711 to
51f28a2
Compare
dazzatronus
force-pushed
the
fix/preview-error-help
branch
from
September 15, 2026 11:51
51f28a2 to
414cc4c
Compare
|
🎉 This PR is included in version 2.19.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media load failures can leave a blank preview without a timeline warning. Surface source-loading failures on the affected clip, including while playback is paused, and explain suspected CORS failures without treating every loading error as CORS.
The warning badge links directly to https://t.shotstack.io/cors in a new tab, with the explanation available in its tooltip. No configuration is required. Dynamic Source validation is unchanged.
Derive the warning from existing loader state: image and video players catch loading errors to draw placeholders, so rejected player promises do not reliably reach the existing clip-failure event. Keep independent video loads separate by clip ID, and ignore stale diagnostic results after a retry.
Verify: Node 22 verification suite passes: 82 suites, 2,064 tests, lint, typecheck, build and package checks. Firefox and Chrome checks cover the warning link, keyboard navigation, clip-menu isolation and narrow layouts.