Repository navigation
Conversation
Member
|
I don't think, we should remove the warning because even with the non-interactive targets being supported by Shutter now, most DEs still don't support them on their backend, so for the user the functionality won't be there. |
Author
|
@Photon89 Agreed. Restored the notice in c385f39 with this wording: “Available capture modes on Wayland depend on your desktop environment. Some modes require manual selection.” It keeps the backend limitation visible without recommending a switch to Xorg. The PR description now states that limitation too. Local testing was on GNOME/Wayland; I haven't verified other desktop environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu and tooltip capture are disabled on Wayland even though the screenshot portal can capture the desktop with these popups visible. Enable both actions in the toolbar, menus, tray, and CLI. Re-enable their existing configurable countdown, request a non-interactive desktop screenshot, then let the user select the popup from the frozen image. Moving the pointer to select a region therefore cannot dismiss the captured popup.
Wayland does not expose X11's popup enumeration through this portal, so these modes require manual region selection after capture. The selector uses source-image coordinates at any preview zoom, rejects empty selections, and treats Cancel/Escape as an abort. Repeating a successful popup capture waits for the configured delay again. Portal authorization remains handled by the desktop; a first-use permission prompt can require reopening the popup and retrying. The legacy portal request omits the version-3 target option, while target-aware portals receive the desktop target.
Also fixes portal cancellation falling through an
evalblock into image processing: area cancellation could callget_width()on an undefined pixbuf, and failures could create history. Errors and cancellation now return before postprocessing; cancelling a repeat preserves the previous successful history. Keep a concise Wayland notice explaining that available capture modes depend on the desktop environment and some modes require manual selection. This replaces the blanket recommendation to switch to Xorg without implying that every portal backend supports every mode.Validation:
G_DEBUG=fatal-criticals.git diff --checkpasses.