Conversation
Change-Id: I24735bad6cd9e8823a0a028151afdc64722d5a8e
Comment hygiene (advisory)No comment-style violations in the lines this branch adds since |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 38.33% 38.58% +0.24%
==========================================
Files 1507 1514 +7
Lines 350580 351027 +447
Branches 40293 40356 +63
==========================================
+ Hits 134410 135435 +1025
+ Misses 186941 186378 -563
+ Partials 29229 29214 -15
🚀 New features to boost your workflow:
|
| { | ||
| case "XAmple": | ||
| m_parser = new XAmpleParser(m_cache, parserDataDir); | ||
| // LT-22708 As of 2026.08.26, this is only called within FLEx from FdoLexiconTests. |
There was a problem hiding this comment.
how expensive would it be to keep this test code out of production code?
There was a problem hiding this comment.
@jasonleenaylor Could you reply to this, please? I suspect that this code is used between Paratext and FLEx...
There was a problem hiding this comment.
I agree that this needs a second look, it might be better to keep parser as null in this file rather than instantiating it, I don't think the parser is being exercicised by the paratext plugin code.
Change-Id: Ie7662021a72fe8e6f47d639d2ea4ea05dc54f3d9
4 participants
Change-Id: I24735bad6cd9e8823a0a028151afdc64722d5a8e
Using XAmple with additional properties can cause a crash per what is in https://jira.sil.org/browse/LT-22708.
This fix has the XAmple parser send a refresh message just after the new list is added. It does cause the Try a Word window to flash and then disappear while the main window also flashes but returns.
I do not know what is causing the Try a Word window to disappear although I suspect it may have to do with the parser running in a separate thread...
This change is