This repository was archived by the owner on Nov 7, 2026. It is now read-only.
Repository navigation
Let a local liblcm build be selected with -p:SilLcmVersion - #158
Merged
Merged
Conversation
The SIL.LCModel.Core pin moves into a SilLcmVersion property, defaulting to FieldWorks' pin (11.0.0-beta0180), mirroring FieldWorks' SilLcmVersion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here: this moves the
SIL.LCModel.Corepin into aSilLcmVersionproperty, so a locally built liblcm can be selected with-p:SilLcmVersion=<stamped version>. The property has the same name as FieldWorks'SilLcmVersion. The default stays FieldWorks' pin,11.0.0-beta0180, so builds are unchanged.Why: we want to test SIL.TextEditing against a local liblcm build that combines open PRs (sillsdev/liblcm#410, #413, #414). That build is packed into a local NuGet feed with a version stamp, the same way FieldWorks'
Manage-LocalLibraries.ps1does it.Evidence: a local run against that build compiles with no API changes. Every project passes except the refusal-sweep tests in
SIL.TextEditing.LCModel.Tests, and those fail as expected: liblcm now accepts the properties and values it used to refuse. That shows which refusals can go once the fixes ship.Next: nothing in this repo. The refusals stay until a liblcm release that includes the fixes is pinned.
🤖 Generated with Claude Code