Skip to content

Properly pass alignment info/score to Serval - #365

Merged
Enkidu93 merged 1 commit into
mainfrom
properly-pass-alignment-info
Sep 14, 2026
Merged

Enkidu93 merged 1 commit into
mainfrom
properly-pass-alignment-info

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Include NULL alignments.

Is there more we need to do in machine.py to fix this? We are already passing the translation scores (unless there's something weird happening under the hood in thot).


This change is Reviewable

@Enkidu93
Enkidu93 requested a review from ddaspit September 11, 2026 21:11
@codecov-commenter

codecov-commenter commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.10%. Comparing base (b152005) to head (8bdb2fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         389      389           
  Lines       24559    24559           
=======================================
  Hits        22620    22620           
  Misses       1939     1939           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93

Copy link
Copy Markdown
Collaborator Author

@ddaspit - just making sure: Did you see my comment? Is this the only machine.py change we need or is there a change to thot or something we need to incorporate?

@Enkidu93
Enkidu93 merged commit 6639917 into main Sep 14, 2026
17 checks passed
@Enkidu93
Enkidu93 deleted the properly-pass-alignment-info branch September 14, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants