At least 2 threads for numexpr ... - #2949
Merged
Merged
Conversation
Member
Author
|
@t2010 you have been waiting for it. |
t20100
approved these changes
Sep 21, 2026
t20100
left a comment
t20100
left a comment
Member
There was a problem hiding this comment.
So tests are fixed, but parallel execution of pyfai can still seg fault and would require the fix in numexpr, right?
Comment on lines
+42
to
+51
| #- PYTHON_DIR: "C:\\Python\\3.11" | ||
| # PYTHON_ARCH: "64" | ||
|
|
||
| # Python 3.12 | ||
| - PYTHON_DIR: "C:\\Python\\3.12" | ||
| PYTHON_ARCH: "64" | ||
| #- PYTHON_DIR: "C:\\Python\\3.12" | ||
| # PYTHON_ARCH: "64" | ||
|
|
||
| # Python 3.13 | ||
| - PYTHON_DIR: "C:\\Python\\3.13" | ||
| PYTHON_ARCH: "64" | ||
| #- PYTHON_DIR: "C:\\Python\\3.13" | ||
| # PYTHON_ARCH: "64" |
Member
There was a problem hiding this comment.
Why commenting those? IMO best to remove
Member
Author
There was a problem hiding this comment.
Because it will be re-shuffled in a week with the arrival of 3.15: I'll keep 3.11 and 3.15 only.
|
|
||
| # Build | ||
| - "python run_tests.py -m" | ||
| # - "python run_pytest.py" |
Member
There was a problem hiding this comment.
Suggested change
| # - "python run_pytest.py" |
Member
Author
|
The bug in numexpr still exist, a AI agent proposed a solution but is is apparently not compatible with 3.13t/3.14t. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2948: prevent crash when NUM_THREADS=1