Repository navigation
test(cadente): wait for error log line before asserting - #55
Merged
Merged
Conversation
The server notifies handlers via OnException before enqueuing the entry on the error LogStream, and LogStream writes to the TextWriter on a background consumer. Reading the StringWriter right after the handler signal could observe it empty. Flush the log stream and poll, up to 3 seconds, before asserting.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CadenteExceptionPropagationTests.RequestException_ReportsToHandlerAndErrorLogis flaky in CI (4 of the last 11 runs failed withString '' does not contain string 'Cadente probe exception.').Cause
HttpServercallshandler.Exception(...)(HttpServer.Core.cs:510) beforeerrorLogStream?.WriteLine(entry)(HttpServer.Core.cs:531), andLogStreamwrites to theTextWriterfrom a background consumer. The test read theStringWriterright after the handler signal, so it could win the race.Change
Test only. After the handler signal, flush the error
LogStreamand poll the writer for up to 3 seconds before asserting. No changes undersrc/; the order of handler notification and logging is untouched.Validation