Repository navigation
fix: keep HandleContext alive when a ForwardingResolver throws - #56
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
When
ForwardingResolver.OnResolveClientAddressthrows,HandleContextcorrectly answers 500, butrequest.remoteAddrstaysnull. In thefinallyblock, the default access log format (%ri) readsHttpRequest.RemoteAddress, which calls the resolver again and throws a second time. That exception escapesHandleContext:AsyncRequestProcessing = falsetheMonitor.Exitis skipped and the server stays locked.Fix
%riuses the already resolvedremoteAddrand no longer calls the resolver again.finallyblock are wrapped intry/catch, and the sync completion,Monitor.Exitand request disposal always run.Test
ThrowingForwardingResolverReturns500AndKeepsServingcovers the default and Cadente engines withAsyncRequestProcessingtrue and false: the resolver throws, the response is 500 and the next request is 200. Without the fix the test host crashes.