Repository navigation
fix(skillgen): skip tags older than the default branch version - #527
Merged
Merged
Conversation
A tag cut from a maintenance branch, such as 1.3.13 while main is at 2.0.0-beta.14, matched its own package.json and opened a pull request on main that rewrote the v2 Skill with 1.x guidance. The pull request always targets the default branch, so a release older than it never has a Skill to update there. A Skill directory named with the package scope, as generate-package-skill names @nuxtjs/seo (nuxtjs-seo), now resolves when a package has several Skills.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to nuxt/scripts#950
❓ Type of change
📚 Description
nuxt/scriptspublishes 2.0.0 betas frommainand keeps a1.xbranch for 1.3 maintenance releases. Av1.3.13tag would match its ownpackage.json, pass provenance, and open a pull request onmainthat rewrites the v2 Skill with 1.x guidance. Skillgen pull requests always target the default branch, so a release older than that branch has no Skill to update there.prepareTagnow skips it withTAG_OLDER_THAN_DEFAULT_BRANCH, comparing versions with semver precedence, prereleases included.When a package holds several Skills, the Skill named after a scoped package now resolves with its scope, as
generate-package-skillnames it (@nuxtjs/seoasnuxtjs-seo), as well as without it. The/skillgenpage and the runbook state the new tag rule.