Repository navigation
feat(skillgen): open nothing when an update changes nothing - #561
Merged
Merged
Conversation
update-package-skill leaves the Skill byte-identical when a release touches nothing it claims. The runner now returns that copy without a review, so the Worker sees no change and opens no pull request. The task context tells the Agent to test only what the release changed, with a 25 turn aim.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to skilld-dev/skilld#223
❓ Type of change
📚 Description
Skillgen updates re-ran the whole authoring workflow. A GLM 5.3 proof on which-nuxt spent 61 of 71 steps re-testing an already-tested Skill and ran out of time before review. skilld-dev/skilld#223 adds
update-package-skill, which tests only what the release changed and leaves the Skill byte-identical when nothing relevant changed.The runner now returns that unchanged copy without a review, so the Worker finds no change and opens no pull request. The task context tells the Agent to test only the lines the release changed and to copy the current Skill first, so a deadline still leaves a candidate.
📝 Migration
The runner still pins
skilld-harness3.6.4, which lacksupdate-package-skill. After askilld-harnessrelease includes skilld-dev/skilld#223, bumpworkers/skill-harness/runner/package.jsonand its lockfile in this pull request, then merge.