fix(release): upload standalone assets before publishing the release - #145
Merged
Merged
Conversation
The repository uses immutable releases, which reject assets once published. v3.0.2 published through changelogithub first, so its asset upload failed with HTTP 422 and npm never published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
v3.0.2 stopped at the asset upload:
This repository has immutable releases on, which is what we want for signed binaries: nobody can swap an asset later. But
changelogithubpublished the release before the upload step ran. The release is now created as a draft, gets every asset, and is published last, after npm. A rerun reuses the draft and refuses a release that is already published.v3.0.2 is locked with no assets and was never published to npm, so the next tag is v3.0.3.