feat(auth): name each sign-in with the computer hostname - #149
Merged
harlan-zw merged 4 commits intoSep 16, 2026
Merged
Conversation
skilld.dev lists CLI sign-ins on the devices page, but the CLI never sent a label, so every entry showed only its token kind.
harlan-zw
added this pull request to stack #150
September 16, 2026 15:00
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 2c0e5401-739b-46c8-9dc0-9fffaba9f2b7 |
harlan-github-agent
Bot
added
harlan-agent-blocked
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #148.
❓ Type of change
📚 Description
skilld.dev lists CLI sign-ins on
/me/devices, but the native CLI never sent a label, so every row just saidoauth.skilld auth loginnow sends the computer hostname asdevice_labelin the token exchange. Control characters are dropped and it stops at 64 characters.Privacy: the label only shows to the account owner and goes away with the token. The README Privacy section now says so and no longer claims "no machine identifiers".
Older skilld.dev deploys strip unknown body keys, so this can ship before the site stores the label.
I went with the hostname since it's what people recognise. The OS name alone would say
linuxfor every box I own. No opt out for now; happy to addSKILLD_DEVICE_LABELif anyone asks.