Skip to content

SK-3222 fix internal release - #439

Open
skyflow-bharti wants to merge 1 commit into
mainfrom
SK-3222-Fix-internal-release
Open

skyflow-bharti wants to merge 1 commit into
mainfrom
SK-3222-Fix-internal-release

Conversation

@skyflow-bharti

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (eecd06a) to head (a9b83ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         174      174           
  Lines        7350     7350           
  Branches     1013     1013           
=======================================
  Hits         6688     6688           
  Misses        437      437           
  Partials      225      225           
Flag Coverage Δ
unittests-flowvault 89.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Module: common 89.15% <ø> (ø)
Module: skyvault 94.95% <ø> (ø)
Module: flowvault 87.93% <ø> (ø)
Service Account 87.36% <ø> (ø)
Vault Data 90.81% <ø> (ø)
Vault Tokens 99.03% <ø> (ø)
Vault Connection 100.00% <ø> (ø)
Vault Controller 82.75% <ø> (ø)
Detect 100.00% <ø> (ø)
Audit 100.00% <ø> (ø)
BIN Lookup 100.00% <ø> (ø)
Config 96.26% <ø> (ø)
Utils 90.36% <ø> (ø)
Errors 100.00% <ø> (ø)
Enums 100.00% <ø> (ø)
Logs 95.60% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecd06a...a9b83ce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration changes are consistent, preserve existing Shade executions, and have no identified blocking issues.

0 open findings

What changed in this PR

Fixes internal release configuration by aligning JFrog repository and credential IDs and consolidating Maven Shade plugin declarations.

Changes:

  • Uses skyflow-jfrog consistently in both modules and the internal release workflow.
  • Consolidates Shade executions under one plugin declaration per module, preserving comparison-only jars.
File Description
skyvault/​pom.xml Consolidates Shade configuration and updates the JFrog repository ID.
flowvault/​pom.xml Consolidates Shade configuration and updates the JFrog repository ID.
.github/​workflows/​internal-release.yml Matches the credential server ID to skyflow-jfrog.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants