Repository navigation
SK-3222 fix internal release - #439
skyflow-bharti wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 174 174
Lines 7350 7350
Branches 1013 1013
=======================================
Hits 6688 6688
Misses 437 437
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The configuration changes are consistent, preserve existing Shade executions, and have no identified blocking issues.
0 open findings
What changed in this PR
Fixes internal release configuration by aligning JFrog repository and credential IDs and consolidating Maven Shade plugin declarations.
Changes:
- Uses
skyflow-jfrogconsistently in both modules and the internal release workflow. - Consolidates Shade executions under one plugin declaration per module, preserving comparison-only jars.
| File | Description |
|---|---|
| skyvault/pom.xml | Consolidates Shade configuration and updates the JFrog repository ID. |
| flowvault/pom.xml | Consolidates Shade configuration and updates the JFrog repository ID. |
| .github/workflows/internal-release.yml | Matches the credential server ID to skyflow-jfrog. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.