Repository navigation
Acknowledge browser file streams - #317
Closed
skolarianer wants to merge 3 commits into
Closed
skolarianer wants to merge 3 commits into
skolarianer wants to merge 3 commits into
Conversation
Contributor
Author
|
One clarification: I understand issue #123 as describing uploads from the browser to the remote session's drive. This PR changes |
skolarianer
force-pushed
the
fix/client-file-stream-acks
branch
from
October 20, 2026 14:57
7f9c494 to
6ccc6f3
Compare
Member
|
Merged in 1.13.3, thanks! Confirmed it on a live SSH session: a file sent from the session never reached the browser on 1.13.2, and with this it downloads straight away. You're right that it's the download direction, so it covers #123 item 4 but not the upload disconnect in item 1. #284 can come out of draft whenever you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser now acknowledges incoming file streams after constructing the
BlobReader, then acknowledges each received blob from its progress callback. This keeps the client file stream's flow control moving as data arrives.Adds a focused Node test for both acknowledgements.
Tested:
git diff --check; node tests/client-file-stream-ack.mjsMay fixes #123 as suggested here: #284 (comment)