Repository navigation
refactor: harden the single-instance pipe server - #979
Merged
Merged
Conversation
Port the single-instance changes: IInstanceActivationEvents becomes IInstanceEvents, the server reports failures through ErrorEventArgs, rejects empty payloads and bounds the read buffer, and the client reports a refused payload as a failed send. Fix a stuck owner: when a client closed during the accept, the failed WaitForConnectionAsync left the stream waiting to connect, where NamedPipeServerStream.Disconnect throws without disconnecting. The instance stayed closing and every later accept failed, so the owner kept the pipe name but answered nobody. The server now disconnects the instance through DisconnectNamedPipe, generated by CsWin32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the single-instance changes: IInstanceActivationEvents becomes IInstanceEvents, the server reports failures through ErrorEventArgs, rejects empty payloads and bounds the read buffer, and the client reports a refused payload as a failed send.
Fix a stuck owner: when a client closed during the accept, the failed WaitForConnectionAsync left the stream waiting to connect, where NamedPipeServerStream.Disconnect throws without disconnecting. The instance stayed closing and every later accept failed, so the owner kept the pipe name but answered nobody. The server now disconnects the instance through DisconnectNamedPipe, generated by CsWin32.