Repository navigation
refactor: persist telemetry through ServerTelemetryChannel - #980
Merged
Merged
Conversation
TelemetryService sends through ServerTelemetryChannel with a local store under .cache\.telemetry, so unsent telemetry survives the process, and waits for delivery when it is disposed. TelemetryConsent gives a configured policy precedence over the user preference; saving the options applies it, since the TelemetryEnabled setter no longer does. Program flushes the process-wide instance before rethrowing a fatal exception and disposes it on a normal exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TelemetryService sends through ServerTelemetryChannel with a local store under .cache.telemetry, so unsent telemetry survives the process, and waits for delivery when it is disposed. TelemetryConsent gives a configured policy precedence over the user preference; saving the options applies it, since the TelemetryEnabled setter no longer does.
Program flushes the process-wide instance before rethrowing a fatal exception and disposes it on a normal exit.