Repository navigation
refactor: compose the host from a bootstrap context - #982
Merged
Merged
Conversation
BootstrapContext owns the logger factory, policies, user settings and telemetry, created before the host and registered in the container as instances, so the container never disposes them. Settings and telemetry failures degrade to defaults and NullTelemetryService. Global exception handling covers AppDomain unhandled exceptions and unobserved task exceptions: the report is saved to ErrorReport.txt and shown in a task dialog that can send it through telemetry. The single instance is created by the container with its logger and telemetry.
Remove the application overview and the startup walkthrough, which repeat AGENTS.md and Program. Replace the logging-sink and flush-timeout tables, which copy code, with the behavior they cause, and drop generic advice from the handled-exception rules. State the uncovered startup failures, including a policy read failure, and the ProblemDetails mapping order constraint. Align the consent wording with the current behavior and wrap at 120 columns.
ADR 0003: fatal exceptions end the process after a saved report and a dialog. ADR 0004: bootstrap services are created outside the container. ADR 0005: a policy read failure stops the startup. ADR 0006: telemetry is sent through a persistent channel. The design documents link them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BootstrapContext owns the logger factory, policies, user settings and telemetry, created before the host and registered in the container as instances, so the container never disposes them. Settings and telemetry failures degrade to defaults and NullTelemetryService.
Global exception handling covers AppDomain unhandled exceptions and unobserved task exceptions: the report is saved to ErrorReport.txt and shown in a task dialog that can send it through telemetry. The single instance is created by the container with its logger and telemetry.