Repository navigation
fix: update MSAL to 4.83.3 so system-browser sign-in works - #987
Merged
Merged
Conversation
The Entra app used by Bravo accepts only response_mode=form_post and rejects the query response mode (AADSTS70007). The loopback listener in MSAL 4.73.1 reads only query responses, so sign-in with the system browser failed. MSAL 4.83.3 uses form_post for the system browser and reads the POST body. This is the same version Power BI Desktop 2.159 ships. MSAL Desktop 4.83.3 requires WebView2 1.0.2903.40 or later. That package references its WPF control in every .NET project, and the WPF assembly built for net5.0 references WindowsBase 5.0, which conflicts with the framework's WindowsBase (MSB3277, WebView2Feedback#4959). Bravo hosts only the WinForms control, so a target in Directory.Build.targets removes the WPF reference before assembly resolution in every SDK-style project, including the test project that gets the package through Bravo. The WPF assembly is no longer copied to the output, so the installer transform stops packaging it. MSAL 4.83 makes the string overload of WithExtraQueryParameters obsolete. msafed=0 is now passed as a static read-only dictionary through the new overload and kept out of the token cache key, because it only filters the accounts offered at sign-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Signing in with "Use system browser for authentication" fails with AADSTS70007 ("unsupported mode"). The Entra app accepts only response_mode=form_post, and the loopback listener in MSAL 4.73.1 reads only query responses.
Change
Verification