Repository navigation
Import objects from older Microsoft Whiteboard boards (1.7.1) - #172
Merged
Merged
Conversation
Boards made with older versions of Microsoft Whiteboard hold AzureImage, LegacyEllipse, and LegacyPolygon objects, which the import listed as left out. Pictures are read as FluidImage is, ellipses take the radii the page draws, and polygons take the kind their corners have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boards made with older versions of Microsoft Whiteboard hold three object types that 1.7.0 did not read, so the import listed them as left out after the import. Five of six teaching boards exported on 29 September showed the message.
AzureImageFluidImageis, with the data URI labelledimage/*LegacyEllipseellipsecentered on the anchor, outline instroke, width and fill in the styleLegacyPolygonpolygonwhose points start at the anchorAn ellipse's radii can differ from its SVG box, in proportion as well as in size. Edge draws the radii, and they are what line up with the ink around the Venn diagrams, so the importer uses them.
Large rectangles come in with rounded corners, because the board has no square-cornered rectangle. This is already listed as a limitation in
docs/microsoft-whiteboard-import.md.Verified by opening all six boards in the application: nothing is left out, and the ellipses, rectangles, and pictures sit in place against the ink. A third synthetic page in the Core smoke tests covers the three types. The solution builds clean and both smoke test harnesses pass.
The version goes to 1.7.1, with a CHANGELOG entry.
🤖 Generated with Claude Code