Repository navigation
Import custom objects from Microsoft Whiteboard (1.7.4) - #179
Merged
Merged
Conversation
A custom object is a widget from a plug-in, named by its kind. The web client registers only examples and draws a gray box for anything else, so the export holds the box and the kind. It becomes a rectangle of its size in that gray, with the kind as its text. Its size is the first one given in pixels, because the widget itself fills its box. Read from the web client's custom widget component, because no sample holds one. It joins the 1.7.4 notes, which is not released yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom objects (
CustomElement) were the last object type in the Microsoft Whiteboard web client that the importer reported as left out. No sample holds one, so the markup was read from the web client's public code, as for #174 to #178.A custom object is a widget from a plug-in, named by its kind in
data-custom-widget-kind. The web client registers only two examples,example.counterandexample.embed. For any other kind, and for every kind when itsEnableCustomElementflag is off, it draws a gray box that fills the object and says the widget is not available or disabled. The box is at least 120 × 80 pixels, and its own size is100%. The export therefore holds the box and the kind, not the widget.The importer makes a custom object a rectangle of its size in the gray the web client draws, with Custom object and the kind as its text. Its size is the first one given in pixels, because a percentage is the widget filling its box; without one it takes the smallest box. A custom object without a kind is still reported.
A new Core smoke test covers a sized, disabled
example.counter, a centered widget with only percentage sizes, and one without a kind. All 19 samples still import unchanged. The solution builds clean and both harnesses pass.With this, every
data-whiteboard-typethe web client names has a reader; what stays reported is content drawn as a placeholder or missing the element that identifies it. 1.7.4 is not released yet, so its notes entry now includes custom objects and the version stays 1.7.4. The import doc describes them.🤖 Generated with Claude Code