Repository navigation
Import placeholders from Microsoft Whiteboard (1.7.4) - #181
Merged
Merged
Conversation
When a feature is off for whoever exports the board, the web client draws a placeholder box in place of a table, a template, or another object, with a title and a description and nothing of the content. Each becomes a white rectangle of the placeholder's size with a light outline and its two lines. A template whose children were drawn is read child by child, and a child can be a placeholder. Read from the web client's placeholder component and stylesheet, because no sample holds one. It joins the 1.7.4 notes, which is not released yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables and templates that the web client drew as placeholders were reported as left out, and so were work items and other kinds drawn the same way. No sample holds one, so the markup was read from the Microsoft Whiteboard web client's public code, as for #174 to #180.
When a feature flag is off for whoever exports the board (
EnableTables,EnableTemplates,EnableWorkItems, and others), the web client draws its placeholder component instead of the content: adiv.unknownObjectholding a title and a description in the board's language indiv.unknownObjectText, and nothing of the content. The exported stylesheet makes it at least 448 × 170 pixels, white, with a shadow and no border.The importer now checks every object for a placeholder before reading it by type. A placeholder becomes a white rectangle of the placeholder's size with its two lines as its text, and a light outline, because the shadow that marks it on the page does not carry over. A template whose children were drawn is still read child by child, and a child that is a placeholder becomes the same box at its place. Placeholders are no longer reported as left out, because the box and its message are what the page shows and they stay on the board.
The export holds no more than that, so a placeholder stays a placeholder. The import doc lists this among what is lost, and the site's export page says so.
A new Core smoke test covers a table drawn as a placeholder, a centered template drawn as one, and a template whose children were drawn with one child drawn as a placeholder. All 19 samples still import unchanged. The solution builds clean and both harnesses pass.
1.7.4 is not released yet, so this adds an entry to its notes and the version stays 1.7.4.
🤖 Generated with Claude Code